Repository navigation
feat(harbor): a QUEUE panel with FIRST, priority and DROP for a paired device - #325
Merged
Merged
Conversation
…d device The SWITCH tab lists the waiters in grant order from the node's status. A paired device gets FIRST (bump), a priority picker and DROP on each one, except for a training or a hold, which the broker refuses to change. POST /v1/board/queue goes from the harbor straight to berthd's socket after the pairing check. There is no gateway route on purpose: agents hold the gateway's API key, and a queue change is the operator's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Berth Next milestone 7b, operator override, harbor part. #324 added
berth queueon the CLI. The plan asks for thesame buttons in the harbor, so the operator can reorder the queue from a phone.
What changes
POST /v1/board/queuetakes{"lease","action","priority"}. It runswriteOK(same-origin,X-Berth: 1, apaired device), checks the body, then sends
OpQueueto berthd's socket withh.ask.writePaths./v1/berth/*routes accept the node API key, and agents hold thatkey. A gateway route would let an agent bump its own requests. Only a paired device can change the queue.
/v1/statuswaiting, ordemo.jsonin demomode.
<select>and DROP. A training ora hold gets no controls.
.sw-priostyles the select like.btn.Proof
TestBoardQueueruns a real broker behind the harbor with a pinned game and two waiters.prio holdgets 409, and a paired drop refuses the waiter with the operator'sreason.
TestBoardActionGatesandTestBoardActionForwardspass with the splitbrokerHarborhelper.disabled on the first row. The picker matches the buttons once
.sw-priois added (before that it was thebrowser's white control). At 390 px DROP wraps to its own line and keeps touch size.
proof.shfull passes.